python3Packages.paver/nose: remove nose and modernize#330858
Merged
gador merged 1 commit intoNixOS:masterfrom Aug 6, 2024
Merged
python3Packages.paver/nose: remove nose and modernize#330858gador merged 1 commit intoNixOS:masterfrom
gador merged 1 commit intoNixOS:masterfrom
Conversation
Sigmanificient
approved these changes
Jul 29, 2024
Member
|
What about adding paver/paver@e71a735 to remove |
Contributor
Author
|
Not sure if it's worth it. The commit version could be buggy for all we know. |
gador
requested changes
Aug 6, 2024
Member
gador
left a comment
There was a problem hiding this comment.
If we modernize paver we might as well change with lib; and dependencies
Addresses NixOS#326513. Disables new tests that require distutils.
3e58a78 to
19746f9
Compare
Member
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 4 packages built:
|
gador
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Addresses #326513. Disables new tests that require distutils.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.