Skip to content

python3Packages.paver/nose: remove nose and modernize#330858

Merged
gador merged 1 commit intoNixOS:masterfrom
lavafroth:python3Packages.paver/nose
Aug 6, 2024
Merged

python3Packages.paver/nose: remove nose and modernize#330858
gador merged 1 commit intoNixOS:masterfrom
lavafroth:python3Packages.paver/nose

Conversation

@lavafroth
Copy link
Contributor

Description of changes

Addresses #326513. Disables new tests that require distutils.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 29, 2024
@Sigmanificient
Copy link
Member

What about adding paver/paver@e71a735 to remove six dependency?

@lavafroth
Copy link
Contributor Author

Not sure if it's worth it. The commit version could be buggy for all we know.

@ofborg ofborg bot requested a review from lovek323 July 29, 2024 14:23
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 29, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 4, 2024
Copy link
Member

@gador gador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we modernize paver we might as well change with lib; and dependencies

Addresses NixOS#326513. Disables new tests that require distutils.
@lavafroth lavafroth force-pushed the python3Packages.paver/nose branch from 3e58a78 to 19746f9 Compare August 6, 2024 05:31
@gador
Copy link
Member

gador commented Aug 6, 2024

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 330858 run on x86_64-linux 1

4 packages built:
  • python311Packages.paver
  • python311Packages.paver.dist
  • python312Packages.paver
  • python312Packages.paver.dist

@gador gador merged commit aeb0b00 into NixOS:master Aug 6, 2024
@lavafroth lavafroth deleted the python3Packages.paver/nose branch January 14, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants