Skip to content

python3Packages.scikit-fuzzy: unstable-2022-11-07 -> unstable-2023-09-14#330854

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:scikit-fuzzy
Aug 22, 2024
Merged

python3Packages.scikit-fuzzy: unstable-2022-11-07 -> unstable-2023-09-14#330854
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Sigmanificient:scikit-fuzzy

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 29, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 29, 2024
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 29, 2024 •
edited
Loading

@emilazy getting this weird build failure from the checkPhase

============================= test session starts ==============================
platform linux -- Python 3.12.4, pytest-7.4.4, pluggy-1.5.0
rootdir: /build/source
configfile: pyproject.toml
collected 166 items / 1 error                                                  
run-last-failure: None

==================================== ERRORS ====================================
____________ ERROR collecting skfuzzy/cluster/tests/test_cmeans.py _____________
import file mismatch:
imported module 'test_cmeans' has this __file__ attribute:
  /build/source/build/lib/skfuzzy/cluster/tests/test_cmeans.py
which is not the same as the test file we want to collect:
  /build/source/skfuzzy/cluster/tests/test_cmeans.py
HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules
=========================== short test summary info ============================
ERROR skfuzzy/cluster/tests/test_cmeans.py
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 1.00s ===============================

@Sigmanificient Sigmanificient mentioned this pull request Jul 29, 2024
Closed
@emilazy
Copy link
Member

emilazy commented Jul 29, 2024

Looks like some issue with running tests out of tree. It’s beyond my expertise without doing a bunch of digging; hopefully someone else can take a look.

@lavafroth
Copy link
Contributor

lavafroth commented Jul 29, 2024 •
edited
Loading

I'll look at the build failures. Looks good otherwise.

@lavafroth
Copy link
Contributor

lavafroth commented Jul 29, 2024

I figured, we gotta remove the build dir during the checkPhase. I added the following:

  checkPhase = ''
    rm -rf build
  '';

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 29, 2024
@ofborg ofborg bot requested a review from bcdarwin July 29, 2024 15:11
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 29, 2024
bcdarwin
bcdarwin reviewed Jul 29, 2024
View reviewed changes
@lavafroth
Copy link
Contributor

lavafroth commented Jul 29, 2024 via email

@bcdarwin
Copy link
Member

bcdarwin commented Jul 29, 2024

I guess that'd be more appropriate, yeah. Also, I just tested that we can run pytest skfuzzy in the checkPhase to point to the appropriate directory.

The current version using preCheck is fine, but in the other case pytestFlagsArray = [ "skfuzzy" ] would be preferred here.

bcdarwin
bcdarwin reviewed Jul 29, 2024
View reviewed changes
jopejoe1
jopejoe1 reviewed Jul 29, 2024
View reviewed changes
@ofborg ofborg bot requested a review from bcdarwin July 29, 2024 17:11
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jul 29, 2024
emilazy
emilazy previously requested changes Aug 9, 2024
View reviewed changes
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Aug 10, 2024

done

@Sigmanificient Sigmanificient requested a review from emilazy August 10, 2024 04:13
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 10, 2024
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Aug 22, 2024

@ofborg build python312Packages.scikit-fuzzy python312Packages.intensity-normalization

@SuperSandro2000 SuperSandro2000 merged commit ffeaefa into NixOS:master Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 jopejoe1 left review comments

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

@emilazy emilazy Awaiting requested review from emilazy

+1 more reviewer

@lavafroth lavafroth lavafroth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Sigmanificient @emilazy @lavafroth @bcdarwin @SuperSandro2000 @jopejoe1