Draft
Conversation
13 tasks
13 tasks
13 tasks
roberth
commented
Oct 21, 2024
Comment on lines
+89
to
+110
| export NIXPKGS_SHELL_TMP="$(mktemp -d --tmpdir nixpkgs-shell-${name}.XXXXXX)" | ||
| export TMPDIR="$NIXPKGS_SHELL_TMP" | ||
| export TEMPDIR="$NIXPKGS_SHELL_TMP" | ||
| export TMP="$NIXPKGS_SHELL_TMP" | ||
| export TEMP="$NIXPKGS_SHELL_TMP" |
Member
Author
There was a problem hiding this comment.
No NIX_BUILD_TOP. Should we have it? It's not a build...
Member
Author
There was a problem hiding this comment.
It is a shell for a build, at least in principle, so yes
This was referenced Jul 20, 2025
Merged
b630090 to
c8c1473
Compare
Some tests use __bootPackages, and we'd like to support that even if we override stdenv, e.g. to add devShell to mkDerivation in a later commit.
c8c1473 to
20ce2bc
Compare
20ce2bc to
3bc9864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Note: this is currently draft, because it does not have sufficient tests and documentation for a number of features.
Help wanted :) This is a
NixOS/nixpkgsbranch, where all maintainers can push, but maybe sync with me first.Implement build shells and development shells in Nixpkgs for greater flexibility and evolution of the Nix shell concept.
nix develop"shell" logic nix#7501nix run -f shell.nix --arg nixpkgs ./. devShell(ie like running the output ofnix-build shell.nix -A devShell)devShellinterface yourself.passthru.devShell = something custom;devShellTools: add environment functions #324789Terminology cheat sheet
nix shell:nix env shellmake-derivation.nix), useful for troubleshooting a buildmkShell, or with other projects likecachix/devenv,numtide/devshell, etc, provided they'll implement thedevShellinterfaceTODO
PATHby default?devShellattribute and the interface of its outputdevShellnix developandnix print-dev-envbehaviors. This is very small and ok to duplicate.)devShellattr for now)mkShellreturn an impure shell by default, because it's for dev shells?nix develop"shell" logic nix#7501Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.