python312Packages.{mwtypes,mwxml}: drop nose dependency; modernize#330805
Merged
GaetanLepage merged 4 commits intoNixOS:masterfrom Aug 1, 2024
Merged
python312Packages.{mwtypes,mwxml}: drop nose dependency; modernize#330805GaetanLepage merged 4 commits intoNixOS:masterfrom
GaetanLepage merged 4 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Thanks for dealing with this. |
Member
|
There are 0.4.0 and 0.3.4 releases from this month that we could presumably use? |
Drops the nose dependency with the new patch
pyrox0
force-pushed
the
denose/mwtypes-and-mwxml
branch
from
a92eff9 to
e766541
Compare
Member
Author
|
Tested and now using the regular pypi releases, and the patches still apply properly. Thanks for the suggestion to double-check that! |
emilazy
approved these changes
Jul 31, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 330805 run on aarch64-linux 1
8 packages built:
- python311Packages.mwtypes
- python311Packages.mwtypes.dist
- python311Packages.mwxml
- python311Packages.mwxml.dist
- python312Packages.mwtypes
- python312Packages.mwtypes.dist
- python312Packages.mwxml
- python312Packages.mwxml.dist
Sigmanificient
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates these two packages to their latest releases to pull in new fixes, as well as adding patches that remove nose from their test suites. Upstream PRs have been sent, and they are linked next to the patches.
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.