python312Packages.pycontracts: drop#330791
Merged
emilazy merged 1 commit intoNixOS:masterfrom Aug 10, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
emilazy
requested changes
Aug 9, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Thanks! This isn’t used by anything and upstream seems pretty dead; maybe it’d be best to drop it rather than patching it up a bunch? If there’s a reason to keep it I’d feel better about a proper .patch as this goes beyond my substituteInPlace comfort zone.
Member
Author
|
I'll change this to drop instead, good call since there is a lot of patching. |
pyrox0
force-pushed
the
denose/pycontracts
branch
from
99a88ac to
5d30219
Compare
pyrox0
changed the title
natsukium
approved these changes
Aug 10, 2024
Member
natsukium
left a comment
natsukium
left a comment
There was a problem hiding this comment.
We can merge when ofborg-eval passes.
ofborg
bot
added
8.has: clean-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Upstream is abandoned and this package no longer works on modern python versions. Since nothing else depends on it, drop the package.
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.