python312Packages.inotify: drop nose dependency; modernize#330776
Merged
emilazy merged 2 commits intoNixOS:masterfrom Oct 11, 2024
Merged
python312Packages.inotify: drop nose dependency; modernize#330776emilazy merged 2 commits intoNixOS:masterfrom
emilazy merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
pyrox0
changed the title
ofborg
bot
added
10.rebuild-darwin: 1-10
emilazy
reviewed
Jul 29, 2024
Member
|
not personally using it, though maybe there are others that are |
Contributor
|
I have never used |
pyrox0
force-pushed
the
denose/inotify
branch
from
3bcbdc3 to
9a61d4d
Compare
pyrox0
force-pushed
the
denose/inotify
branch
from
9a61d4d to
96eb0d2
Compare
emilazy
approved these changes
Oct 11, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Thanks for all your great work on this project; we couldn’t have done it without you and it looks like we’re on track to remove nose for 24.11 :) I’m looking into the remaining two packages without open PRs, but if I don’t get around to it in the next day or two you can feel free to pick them up if you feel like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.