Skip to content

python312Packages.pyutilib: drop#330759

Merged
natsukium merged 1 commit intoNixOS:masterfrom
pyrox0:pythonpackages/drop-pyutilib
Jul 29, 2024
Merged

python312Packages.pyutilib: drop#330759
natsukium merged 1 commit intoNixOS:masterfrom
pyrox0:pythonpackages/drop-pyutilib

Conversation

@pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 29, 2024

Description of changes

Part of #326513
Per PyUtilib/pyutilib#117, it is unmaintained and the last commit being 4 years ago(as of writing) agrees with that. There are many critical issues that break the library on present and future python versions, notably that its test runner nose does not work on 3.12+ and the python standard library imp module is also not available in 3.12+.`

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pyrox0 pyrox0 requested a review from natsukium as a code owner July 29, 2024 02:40
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 29, 2024
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to pkgs/top-level/python-aliases.nix.

Per PyUtilib/pyutilib#117, it is unmaintained
and the last commit being 4 years ago(as per writing this commit
message) agrees with that.
@pyrox0 pyrox0 force-pushed the pythonpackages/drop-pyutilib branch from 56efeae to e742f46 Compare July 29, 2024 03:15
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 29, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They didn’t even merge the deprecation PR… 😅

Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@natsukium natsukium merged commit 238edcd into NixOS:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants