python312Packages.python-hglib: Remove nose dependency; modernize#330739
Merged
emilazy merged 5 commits intoNixOS:masterfrom Jul 31, 2024
Merged
python312Packages.python-hglib: Remove nose dependency; modernize#330739emilazy merged 5 commits intoNixOS:masterfrom
emilazy merged 5 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
pyrox0
force-pushed
the
denose/python-hglib
branch
from
c82c93a to
0104528
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
pyrox0
changed the title
emilazy
requested changes
Jul 29, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Great work, thank you! Just a couple nits.
pyrox0
force-pushed
the
denose/python-hglib
branch
from
0104528 to
d4b2b01
Compare
pyrox0
force-pushed
the
denose/python-hglib
branch
from
d4b2b01 to
43a5b1e
Compare
emilazy
approved these changes
Jul 31, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 330739 run on aarch64-linux 1
21 packages built:
- mozillavpn
- mozphab
- mozphab.dist
- powerline (python312Packages.powerline)
- powerline.dist (python312Packages.powerline.dist)
- python311Packages.glean-parser
- python311Packages.glean-parser.dist
- python311Packages.glean-sdk
- python311Packages.glean-sdk.dist
- python311Packages.powerline
- python311Packages.powerline.dist
- python311Packages.python-hglib
- python311Packages.python-hglib.dist
- python312Packages.glean-parser
- python312Packages.glean-parser.dist
- python312Packages.glean-sdk
- python312Packages.glean-sdk.dist
- python312Packages.python-hglib
- python312Packages.python-hglib.dist
- sourcehut.hgsrht
- sourcehut.hgsrht.dist
Member
|
I assume the |
Member
Author
|
Yes, it uses the lmdb-rkv-sys crate |
Member
|
Do you know if we can easily get it to use the system |
Member
Author
|
I'm not sure, as I've never used the crate before, and I'm not familiar with rust development. I'll look into it, but no guarantees that I can get anything working lol |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #326513
This required a few more patches and fixes to other packages than I would like, but this does allow all dependents of python-hglib to build and test properly.
Updates:
Changes:
mozphabhas 3 failing tests disabledThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.