Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
This was referenced Jul 29, 2024
drupol
reviewed
Jul 31, 2024
emilazy
force-pushed
the
push-lsuzwplvkpsw
branch
from
41f8cea to
cb97336
Compare
natsukium
approved these changes
Aug 1, 2024
Member
natsukium
left a comment
natsukium
left a comment
There was a problem hiding this comment.
I don't know how many active upstreams actually use nose in 2024, but it's fine for me to package it as long as the other packages in nixpkgs don't depend on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
They said nobody could get a new package using nose into Nixpkgs… they were wrong!!!
Obviously there is an element of farce here, but I just used this to accomplish yandex/gixy#146 and I suspect it may come in handy for others working on #326513 or who just have their own nose test suites they’d like to migrate. The upstream package declares that it doesn’t work on Python 3.12, I guess because the nose‐using tests won’t natively run on that version, but it seems to work fine for me.
Of course, I’ll remove the nose
nativeCheckInputand just disable the tests when the time comes. (Or now, if other people don’t find it as amusing as I do.)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.