Skip to content

libheif: 1.18.0 -> 1.18.2#330711

Merged
fabianhjr merged 1 commit intoNixOS:stagingfrom
trofi:libheif-update
Aug 16, 2024
Merged

libheif: 1.18.0 -> 1.18.2#330711
fabianhjr merged 1 commit intoNixOS:stagingfrom
trofi:libheif-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jul 28, 2024 •
edited
Loading

Changes:

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from gebner July 28, 2024 23:13
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 28, 2024
@euank
Copy link
Member

euank commented Aug 12, 2024

It looks like there's a v1.18.2 now; it could be worth bumping straight to that!

@trofi trofi changed the title libheif: 1.18.0 -> 1.18.1 libheif: 1.18.0 -> 1.18.2 Aug 12, 2024
@trofi
Copy link
Contributor Author

trofi commented Aug 12, 2024

It looks like there's a v1.18.2 now; it could be worth bumping straight to that!

Good catch! Updated to 1.18.2.

euank
euank approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

I also checked that imagemagick.passthru.tests is happy, and vips builds, since those are downstream packages I use.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 14, 2024
@fabianhjr fabianhjr merged commit fe386b2 into NixOS:staging Aug 16, 2024
@trofi trofi deleted the libheif-update branch August 16, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gebner gebner Awaiting requested review from gebner

1 more reviewer

@euank euank euank approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trofi @euank @fabianhjr @wegank