python312Packages.pycdio: drop nose dependency#330695
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
|
Btw this would fix this issue: #331094 |
There was a problem hiding this comment.
Can’t this just be "test" (or "test/")?
There was a problem hiding this comment.
Probably, we can't. The upstream uses - instead of _.
https://docs.pytest.org/en/7.1.x/explanation/goodpractices.html#conventions-for-python-test-discovery
There was a problem hiding this comment.
This works and would be more robust to future additions of tests:
| pytestFlagsArray = [ | |
| "test/test-cdio.py" | |
| "test/test-cdtext.py" | |
| "test/test-iso.py" | |
| "test/test-isocopy.py" | |
| ]; | |
| pytestFlagsArray = [ "test/test-*.py" ]; |
|
GitHub is hiding my additional comment: the |
|
Change sources to the GitHub repo andadopted the package Sadly tests are indeed not found when setting |
ofborg
bot
added
the
11.by: package-maintainer
There was a problem hiding this comment.
This works and would be more robust to future additions of tests:
| pytestFlagsArray = [ | |
| "test/test-cdio.py" | |
| "test/test-cdtext.py" | |
| "test/test-iso.py" | |
| "test/test-isocopy.py" | |
| ]; | |
| pytestFlagsArray = [ "test/test-*.py" ]; |
5 participants
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.