Skip to content

python312Packages.pygatt: drop nose#330688

Closed
Sigmanificient wants to merge 1 commit intoNixOS:masterfrom
Sigmanificient:pygatt
Closed

python312Packages.pygatt: drop nose#330688
Sigmanificient wants to merge 1 commit intoNixOS:masterfrom
Sigmanificient:pygatt

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 28, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 28, 2024
@ofborg ofborg bot requested a review from fabaff July 28, 2024 19:47
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 28, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work on upstreaming this!

@emilazy
Copy link
Member

emilazy commented Jul 28, 2024

Oh, also, typo: “gygatt”.

@Sigmanificient Sigmanificient changed the title python312Packages.gygatt: 4.0.5 -> 4.0.5-unstable-2021-09-13, drop nose python312Packages.pygatt: 4.0.5 -> 4.0.5-unstable-2021-09-13, drop nose Jul 29, 2024
@Sigmanificient Sigmanificient requested a review from emilazy July 29, 2024 15:42
@Sigmanificient
Copy link
Member Author

Will wait for fabaff, mweinelt & emilazy to agree on a final answer 😅

@emilazy
Copy link
Member

emilazy commented Aug 9, 2024

Pending on rebase and review comments.

@Sigmanificient Sigmanificient changed the title python312Packages.pygatt: 4.0.5 -> 4.0.5-unstable-2021-09-13, drop nose python312Packages.pygatt: drop nose Aug 10, 2024
@emilazy
Copy link
Member

emilazy commented Aug 10, 2024

Handled by #332660. Thanks for getting the patch upstreamed!

@emilazy emilazy closed this Aug 10, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants