Skip to content

python3Packages.androguard: drop nose dependency; python3Packages.nose-timer: drop#330535

Merged
natsukium merged 4 commits intoNixOS:masterfrom
emilazy:push-tuyuqtmztxvv
Jul 28, 2024
Merged

python3Packages.androguard: drop nose dependency; python3Packages.nose-timer: drop#330535
natsukium merged 4 commits intoNixOS:masterfrom
emilazy:push-tuyuqtmztxvv

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Jul 27, 2024

Description of changes

#326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from natsukium as a code owner July 27, 2024 23:42
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 27, 2024
@emilazy emilazy force-pushed the push-tuyuqtmztxvv branch from c8a03a4 to 741a8a7 Compare July 28, 2024 00:05
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Jul 28, 2024
@ofborg ofborg bot requested a review from pmiddend July 28, 2024 00:45
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 28, 2024
@emilazy emilazy force-pushed the push-tuyuqtmztxvv branch from 741a8a7 to c81a64a Compare July 28, 2024 11:25
@emilazy
Copy link
Member Author

emilazy commented Jul 28, 2024

Even I forget to pyprojectize sometimes…

Result of nixpkgs-review pr 330535 run on x86_64-linux 1

14 packages built:
  • androguard (python312Packages.androguard)
  • androguard.dist (python312Packages.androguard.dist)
  • apkleaks
  • apkleaks.dist
  • diffoscope
  • diffoscope.dist
  • diffoscope.man
  • fdroidserver
  • fdroidserver.dist
  • jadx
  • python311Packages.androguard
  • python311Packages.androguard.dist
  • quark-engine
  • quark-engine.dist

@emilazy emilazy force-pushed the push-tuyuqtmztxvv branch from c81a64a to 4d10225 Compare July 28, 2024 11:37
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@natsukium natsukium merged commit 06b2e48 into NixOS:master Jul 28, 2024
@emilazy emilazy deleted the push-tuyuqtmztxvv branch August 26, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants