Skip to content

python3Packages.pylacrosse: drop nose dependency#330500

Merged
emilazy merged 1 commit intoNixOS:masterfrom
Sigmanificient:pylacrosse
Jul 27, 2024
Merged

python3Packages.pylacrosse: drop nose dependency#330500
emilazy merged 1 commit intoNixOS:masterfrom
Sigmanificient:pylacrosse

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 27, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 27, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure how this one fell through the cracks of my grep script.

Edit: Oh, it didn’t, I just missed it when going to add this 🙃

Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330500 run on x86_64-linux 1

4 packages built:
  • python311Packages.pylacrosse
  • python311Packages.pylacrosse.dist
  • python312Packages.pylacrosse
  • python312Packages.pylacrosse.dist

@emilazy emilazy merged commit 0b10556 into NixOS:master Jul 27, 2024
@Sigmanificient Sigmanificient deleted the pylacrosse branch July 27, 2024 21:15
@ofborg ofborg bot requested a review from fabaff July 27, 2024 21:19
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants