ananicy-cpp: make bpfSupport optional#330488
Merged
JohnRTitor merged 2 commits intoNixOS:masterfrom Jul 28, 2024
Merged
Conversation
use lib.cmakeBool and lib.cmakeFeature switch to finalAttrs from recursion format with nixfmt-rfc-style
Contributor
|
I already started working on that. |
Contributor
|
I think we can use stdenv instead of clangStdenv with |
Contributor
|
Haven't checked yet, but we can probably make |
Member
Author
According to the docs, we could use |
Contributor
|
I think the option should be named |
ananicy-cpp compiled with bpf does not work on hardened kernels So we make it optional to allow users to disable it NixOS#327382
ofborg
bot
added
11.by: package-maintainer
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
ananicy-cpp compiled with bpfSupport does not work on hardened kernels
So we make it optional to allow users to disable it.
#327382
This is still enabled by default.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.