python312Packages.pysrt: drop nose dependency#330441
Merged
emilazy merged 1 commit intoNixOS:masterfrom Jul 27, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
Sigmanificient
force-pushed
the
pysrt
branch
2 times, most recently
from
21d4c38 to
81a49b9
Compare
Sigmanificient
changed the title
ofborg
bot
added
8.has: package (new)
Member
|
Please migrate to |
emilazy
requested changes
Jul 27, 2024
emilazy
approved these changes
Jul 27, 2024
emilazy
requested changes
Jul 27, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Uh, spoke too soon.
=================================== FAILURES ===================================
______________________________ TestSlice.test_at _______________________________
self = <tests.test_srtfile.TestSlice testMethod=test_at>
def test_at(self):
> self.assertEquals(len(self.file.at((0, 0, 31, 0))), 1)
E AttributeError: 'TestSlice' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
tests/test_srtfile.py:120: AttributeError
_________________________ TestText.test_multiple_item __________________________
self = <tests.test_srtfile.TestText testMethod=test_multiple_item>
def test_multiple_item(self):
srt_file = SubRipFile([
SubRipItem(1, {'seconds': 0}, {'seconds': 3}, 'Hello'),
SubRipItem(1, {'seconds': 1}, {'seconds': 2}, 'World !')
])
> self.assertEquals(srt_file.text, 'Hello\nWorld !')
E AttributeError: 'TestText' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
tests/test_srtfile.py:147: AttributeError
__________________________ TestText.test_single_item ___________________________
self = <tests.test_srtfile.TestText testMethod=test_single_item>
def test_single_item(self):
srt_file = SubRipFile([
SubRipItem(1, {'seconds': 1}, {'seconds': 2}, 'Hello')
])
> self.assertEquals(srt_file.text, 'Hello')
E AttributeError: 'TestText' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
tests/test_srtfile.py:140: AttributeError
_____________________ TestIntegration.test_missing_indexes _____________________
self = <tests.test_srtfile.TestIntegration testMethod=test_missing_indexes>
def test_missing_indexes(self):
items = pysrt.open(os.path.join(self.base_path, 'no-indexes.srt'))
> self.assertEquals(len(items), 7)
E AttributeError: 'TestIntegration' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
tests/test_srtfile.py:254: AttributeError
________________ TestSerialAndParsing.test_junk_after_timestamp ________________
self = <tests.test_srtitem.TestSerialAndParsing testMethod=test_junk_after_timestamp>
def test_junk_after_timestamp(self):
item = SubRipItem.from_string(self.junk_after_timestamp)
> self.assertEquals(item, self.item)
E AttributeError: 'TestSerialAndParsing' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
tests/test_srtitem.py:210: AttributeError
______________________ TestSerialAndParsing.test_no_index ______________________
self = <tests.test_srtitem.TestSerialAndParsing testMethod=test_no_index>
def test_no_index(self):
item = SubRipItem.from_string(self.no_index)
> self.assertEquals(item.index, None)
E AttributeError: 'TestSerialAndParsing' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
tests/test_srtitem.py:205: AttributeError
____________________ TestSerialAndParsing.test_string_index ____________________
self = <tests.test_srtitem.TestSerialAndParsing testMethod=test_string_index>
def test_string_index(self):
item = SubRipItem.from_string(self.string_index)
> self.assertEquals(item.index, 'foo')
E AttributeError: 'TestSerialAndParsing' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?
tests/test_srtitem.py:200: AttributeError
=========================== short test summary info ============================
FAILED tests/test_srtfile.py::TestSlice::test_at - AttributeError: 'TestSlice' object has no attribute 'assertEquals'. Did you...
FAILED tests/test_srtfile.py::TestText::test_multiple_item - AttributeError: 'TestText' object has no attribute 'assertEquals'. Did you ...
FAILED tests/test_srtfile.py::TestText::test_single_item - AttributeError: 'TestText' object has no attribute 'assertEquals'. Did you ...
FAILED tests/test_srtfile.py::TestIntegration::test_missing_indexes - AttributeError: 'TestIntegration' object has no attribute 'assertEquals'. D...
FAILED tests/test_srtitem.py::TestSerialAndParsing::test_junk_after_timestamp - AttributeError: 'TestSerialAndParsing' object has no attribute 'assertEqual...
FAILED tests/test_srtitem.py::TestSerialAndParsing::test_no_index - AttributeError: 'TestSerialAndParsing' object has no attribute 'assertEqual...
FAILED tests/test_srtitem.py::TestSerialAndParsing::test_string_index - AttributeError: 'TestSerialAndParsing' object has no attribute 'assertEqual...
========================= 7 failed, 68 passed in 0.45s =========================
Member
Author
|
Hopefully it's good now |
Member
Author
|
Almost forget the license change |
emilazy
reviewed
Jul 27, 2024
Comment on lines
28
to
33
Member
There was a problem hiding this comment.
This was actually fixed upstream; it might be better to just pin to the latest Git commit, or vendor the relevant commit. This is fine too though so I’ll merge if you don’t feel like doing that.
Member
|
Result of 4 packages marked as broken and skipped:
4 packages built:
|
emilazy
approved these changes
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.