Skip to content

python3Packages.weboob: drop#330436

Merged
emilazy merged 1 commit intoNixOS:masterfrom
lavafroth:woob-duplicate
Jul 28, 2024
Merged

python3Packages.weboob: drop#330436
emilazy merged 1 commit intoNixOS:masterfrom
lavafroth:woob-duplicate

Conversation

@lavafroth
Copy link
Contributor

@lavafroth lavafroth commented Jul 27, 2024

Description of changes

Addresses #326513
superseded by python3Packages.woob

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lavafroth lavafroth requested a review from natsukium as a code owner July 27, 2024 15:23
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 27, 2024
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 27, 2024
@Sigmanificient
Copy link
Member

ofborg-eval — Failed to merge

@lavafroth
Copy link
Contributor Author

Seems like the default.nix file was edited since the commit on master that I have locally. Due to my flaky internet connection, I can't pull all the 4000+ commits that my fork is behind.

@emilazy
Copy link
Member

emilazy commented Jul 27, 2024

I can rebase this and push to your branch, if you’d like?

@lavafroth
Copy link
Contributor Author

lavafroth commented Jul 27, 2024 via email

superseded by python3Packages.woob
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It‘s been an honour to collaborate on removing a file.

@emilazy emilazy merged commit 4b4a3bf into NixOS:master Jul 28, 2024
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jul 28, 2024
@lavafroth
Copy link
Contributor Author

gg thanks.

@lavafroth lavafroth deleted the woob-duplicate branch July 28, 2024 03:03
@emilazy emilazy mentioned this pull request Jul 28, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants