Merged
Conversation
github-actions
bot
added
the
6.topic: python
Member
|
I’m inclined to drop this; no in‐tree users, and “OAuth library that hasn’t been updated in a decade” is a very scary sequence of words. OAuth is security-critical and tricky, and there have certainly been OAuth best practices established in the past decade since this was touched at all. I suspect the only reason there isn’t an obvious |
Sigmanificient
force-pushed
the
rauth
branch
2 times, most recently
from
cef182f to
1504d69
Compare
Member
Author
...yeah that is indeed quite scary 😅 |
Member
|
LGTM. Please update the commit and PR titles. |
Sigmanificient
changed the title
ofborg
bot
added
8.has: clean-up
emilazy
approved these changes
Jul 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.