python312Packages.chart-studio: Remove nose dependency#330248
Merged
emilazy merged 3 commits intoNixOS:masterfrom Aug 10, 2024
Merged
python312Packages.chart-studio: Remove nose dependency#330248emilazy merged 3 commits intoNixOS:masterfrom
emilazy merged 3 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
emilazy
requested changes
Jul 26, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
This is a weird one: it hasn’t seen a release in years but we just get it from the release tags of the Git repository it’s colocated in. I think we should change version to "1.1.0-unstable-YYYY-MM-DD" to reflect the actual last PyPI release version, but it’s okay to keep getting it from Git because it contains more fixes. One of those fixes is removing the six dependency, so let’s get rid of it here too.
ofborg
bot
added
8.has: package (new)
pyrox0
force-pushed
the
denose/chart-studio
branch
2 times, most recently
from
787021b to
7d98fe6
Compare
emilazy
requested changes
Jul 26, 2024
pyrox0
force-pushed
the
denose/chart-studio
branch
2 times, most recently
from
f7e7ac6 to
b344b04
Compare
Member
|
There’s a conflict because Aleksanaa beat you to the Edit: actually it was Mic92. |
pyrox0
force-pushed
the
denose/chart-studio
branch
from
b344b04 to
30eac97
Compare
pyrox0
force-pushed
the
denose/chart-studio
branch
from
30eac97 to
55e56b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.