Skip to content

python312Packages.citeproc-py: Remove nose dependency and re-enable tests#330237

Merged
emilazy merged 2 commits intoNixOS:masterfrom
pyrox0:denose/citeproc-py
Jul 26, 2024
Merged

python312Packages.citeproc-py: Remove nose dependency and re-enable tests#330237
emilazy merged 2 commits intoNixOS:masterfrom
pyrox0:denose/citeproc-py

Conversation

@pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 26, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 26, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this project might actually be becoming active again. They’ve moved to pynose upstream, but just as a test runner, so using pytestCheckHook should be fine.

There have been a bunch of fix commits since the last release, so maybe we should pin an unstable version until they figure out doing releases again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilazy
Copy link
Member

emilazy commented Jul 26, 2024

(Sorry about all the nitpicking! I really appreciate everyone taking the initiative to deal with this massive list of packages; I just want to make sure we do what we can to get packages in a good state or else get rid of unnecessary burdens in the process.)

@ofborg ofborg bot requested a review from bcdarwin July 26, 2024 20:33
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 26, 2024
@pyrox0
Copy link
Member Author

pyrox0 commented Jul 26, 2024

No worries! I appreciate the nitpicks, they help improve future packages I submit and/or update!

@pyrox0 pyrox0 force-pushed the denose/citeproc-py branch from 8cc35a6 to 371dc89 Compare July 26, 2024 22:15
@pyrox0 pyrox0 force-pushed the denose/citeproc-py branch from 371dc89 to fdc84b4 Compare July 26, 2024 22:15
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 330237 run on x86_64-darwin 1

8 packages built:
  • python311Packages.citeproc-py
  • python311Packages.citeproc-py.dist
  • python311Packages.duecredit
  • python311Packages.duecredit.dist
  • python312Packages.citeproc-py
  • python312Packages.citeproc-py.dist
  • python312Packages.duecredit
  • python312Packages.duecredit.dist

@emilazy emilazy merged commit 638c11c into NixOS:master Jul 26, 2024
@pyrox0 pyrox0 deleted the denose/citeproc-py branch August 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants