Treewide: remove inactive maintainer viric#330232
Treewide: remove inactive maintainer viric#330232Mic92 merged 3 commits intoNixOS:masterfrom atorres1985-contrib:remove-viric
Conversation
github-actions
bot
added
6.topic: python
|
For the future merger: |
Mic92
left a comment
Mic92
left a comment
There was a problem hiding this comment.
Fine with me let's wait 1-2 days for a response.
viric
left a comment
viric
left a comment
There was a problem hiding this comment.
I confirm I'm an inactive maintainer.
|
Okay. Than we can merge it right away after eval. |
ofborg
bot
added
10.rebuild-darwin: 0
|
I want to add myself for |
Since theey is not active from at least six years.
Since theey is not active from at least six years.
Better: |
|
As the first person to encounter the unused with error due to this, can you share your thoughts on this? 😄🎙️ |
pkgs/applications/networking/instant-messengers/silc-client/default.nix
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
| maintainers = with lib.maintainers; [ ]; | |
| maintainers = [ ]; |
ofborg
bot
added
10.rebuild-linux: 1-10
|
I will fix empty maintainer lists using the |
Since theey is not active from at least six years. All the packages on this commit became orphans. --------------------------------------------------------------------------- There are files not covered by this commit, because they will be adopted soon. Namely: - pkgs/by-name/zs/zsync/package.nix - pkgs/games/bsdgames/default.nix - pkgs/misc/ghostscript/default.nix - pkgs/os-specific/linux/kernel/perf/default.nix - pkgs/tools/system/logrotate/default.nix
I have mixed feelings about this. In a first sight, I left the packages that way because a not so long time ago it was recommended - something about "it would be easier to add new maintainers in the future". On the other hand, now that CI reports this as an error, there is no more room to never-ending discussions. The net result of being shot by an error was positive! |
|
I think overall having detection for unused with statements is quite useful, while having an exception just for |
|
The discussion moved away from the actual topic of the PR AFAICS... how about we merge this? |
I can solve this with a bit of emacs-fu. Now CI is happy! |
|
I thought, I pressed the merge button already... must have timed out. |
|
This removal PR has already been merged, despite not being grounded within community consensus. See #337478 (comment) @viric be sure that we value your involvement and any time you may have to spare, helping with the packages you've maintained and others as well, and if you decide to come back, please don't hesitate to be added to maintainers again. |
8 participants
Description of changes
#290642
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.