python312Packages.sampledata: drop#330029
Merged
emilazy merged 1 commit intoNixOS:masterfrom Jul 27, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
Sigmanificient
force-pushed
the
sampledata
branch
2 times, most recently
from
eb235d1 to
1a97585
Compare
ofborg
bot
added
10.rebuild-darwin: 0
emilazy
requested changes
Jul 26, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Unmaintained for 7 years, not a single reverse dependency on PyPI, let’s just drop this.
Member
Author
|
How do you compute rev deps? |
Member
|
Wheelodex for PyPI, |
Sigmanificient
force-pushed
the
sampledata
branch
from
1a97585 to
a1f65b7
Compare
Member
Author
|
How dropping it caused a merge conflict 😅 |
Sigmanificient
force-pushed
the
sampledata
branch
from
a1f65b7 to
246717e
Compare
Member
|
Looks good; please fix the commit and PR messages. |
Sigmanificient
changed the title
python312Package.sampledata: drop
Sigmanificient
force-pushed
the
sampledata
branch
from
246717e to
4355075
Compare
Member
emilazy
approved these changes
Jul 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of: #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.