Skip to content

python312Package.sure: drop nose dependency#330012

Merged
emilazy merged 3 commits intoNixOS:stagingfrom
Sigmanificient:sure
Jul 27, 2024
Merged

python312Package.sure: drop nose dependency#330012
emilazy merged 3 commits intoNixOS:stagingfrom
Sigmanificient:sure

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024

Description of changes

Part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 26, 2024
@emilazy emilazy mentioned this pull request Jul 26, 2024
Closed
emilazy
emilazy requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please migrate to pyproject = true; at the same time.

Maybe we should consider bumping this to 3.0a2, which seems to have removed the nose dependency entirely. I don’t know if it has breaking changes or not, though.

@Sigmanificient Sigmanificient force-pushed the sure branch 2 times, most recently from ef213d3 to 1de0bd0 Compare July 27, 2024 00:06
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 27, 2024

Well there isn't any tags for 3.0.1a and it hasn't yet been updated on pypi too (https://pypi.org/project/sure/#files), so I believe the intent of the developer is to keep working on it before doing the release

@Sigmanificient Sigmanificient requested a review from emilazy July 27, 2024 00:23
emilazy
emilazy reviewed Jul 27, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.0a2 is on PyPI if you look at the right page, but it’s fine to wait for a final release.

@Sigmanificient Sigmanificient requested a review from emilazy July 27, 2024 00:55
emilazy
emilazy approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built python{311,312}Packages.sure on x86_64-darwin, x86_64-linux, and aarch64-linux. Since thousands of packages depend on this one, I haven’t tested the full tree, but as this is a tests‐only change it shouldn’t propagate further. Retargetting to staging for the merge.

@emilazy emilazy marked this pull request as draft July 27, 2024 01:51
@emilazy emilazy changed the base branch from master to staging July 27, 2024 01:52
@emilazy emilazy marked this pull request as ready for review July 27, 2024 01:53
natsukium
natsukium approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emilazy emilazy merged commit daacb4e into NixOS:staging Jul 27, 2024
@Sigmanificient Sigmanificient deleted the sure branch July 27, 2024 02:27
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy approved these changes

@natsukium natsukium natsukium approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @emilazy @natsukium