python312Packages.telfhash: drop nose dependency#330005
Merged
emilazy merged 2 commits intoNixOS:masterfrom Jul 27, 2024
Merged
python312Packages.telfhash: drop nose dependency#330005emilazy merged 2 commits intoNixOS:masterfrom
emilazy merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
emilazy
requested changes
Jul 26, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Please migrate to pyproject = true; at the same time.
| checkPhase = '' | ||
| nosetests | ||
| ''; | ||
| doCheck = false; # no tests |
Member
Author
There was a problem hiding this comment.
From what I can see there really is just no tests in the codebase, and @natsukium prefers that this is explicitely set
emilazy
approved these changes
Jul 27, 2024
| checkPhase = '' | ||
| nosetests | ||
| ''; | ||
| doCheck = false; # no tests |
natsukium
reviewed
Jul 27, 2024
Comment on lines
+26
to
+28
| --replace-fail "python-tlsh" "tlsh" \ | ||
| --replace-fail "py-tlsh" "tlsh" \ | ||
| --replace-fail "nose>=1.3.7" "" |
Member
There was a problem hiding this comment.
nits: you can use pythonRemoveDeps here.
Member
There was a problem hiding this comment.
I didn’t know about that, thank you! Sorry for not catching this. At least it was already present before in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
No tests are present, remove
noseand setdoCheck = false;part of: #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.