Skip to content

python311Packages.yanc: drop#329978

Merged
emilazy merged 1 commit intoNixOS:masterfrom
Sigmanificient:yanc
Jul 27, 2024
Merged

python311Packages.yanc: drop#329978
emilazy merged 1 commit intoNixOS:masterfrom
Sigmanificient:yanc

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024

Description of changes

Remove nose tests which are disable for python > 3.5, long EOL.

Part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 25, 2024
@Sigmanificient Sigmanificient changed the title python311Packages.yanc: drop tests python311Packages.yanc: drop python3.5 (older) nose tests Jul 25, 2024
@Sigmanificient
Copy link
Member Author

CI is failling with:

"Error: Response status code does not indicate success: 429 (Too Many Requests)."

@ofborg ofborg bot requested a review from jluttine July 25, 2024 20:54
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 25, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a post‐processor for nose output. It doesn’t make any sense to try and fix it in the process of removing nose. Instead, it should be removed.

The only reverse dependency in‐tree is python3Packages.preggy. It looks like it should work fine with a simple pytestCheckHook instead.

@Sigmanificient Sigmanificient changed the title python311Packages.yanc: drop python3.5 (older) nose tests python311Packages.yanc: drop Jul 27, 2024
@natsukium
Copy link
Member

Result of nixpkgs-review pr 329978 at 2e9f2c21 run on x86_64-linux 1

2 packages built successfully:
  • python311Packages.preggy
  • python312Packages.preggy

@emilazy emilazy merged commit 8318c84 into NixOS:master Jul 27, 2024
@Sigmanificient Sigmanificient deleted the yanc branch July 27, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants