kdePackages: fix under strictDeps#329977
Merged
K900 merged 1 commit intoNixOS:stagingfrom Jul 26, 2024
Merged
Conversation
13 tasks
ofborg
bot
added
10.rebuild-darwin-stdenv
Contributor
thanks for fixing! could #318226 and #324951 get dropped from the change set and then this just merged into staging? the changes you made should be fine with or without the fixed cmake. i've made some modifications to #318226 in the interface into cmake which probably will cause conflicts with this PR when merged |
K900
force-pushed
the
kdepackages-strictdeps
branch
from
ad36a2d to
6149730
Compare
Contributor
Author
|
Yeah, let's do that. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Supersedes #329822, includes #318226 and #324951 so should be merged after those. Everything builds except Qt5 stuff (expected) and possibly Kalzium (blocked by openbabel Python 3.12 breakage)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.