Skip to content

python311Packages.trfl: remove#329976

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Sigmanificient:trfl
Aug 23, 2024
Merged

python311Packages.trfl: remove#329976
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
Sigmanificient:trfl

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Jul 25, 2024 •
edited
Loading

Description of changes

Part of:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 25, 2024
eclairevoyant
eclairevoyant reviewed Jul 25, 2024
View reviewed changes
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Jul 25, 2024

Forget to commit it 😅

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 26, 2024
@natsukium natsukium requested a review from onny July 26, 2024 01:47
@emilazy
Copy link
Member

emilazy commented Jul 26, 2024

This is still used by python3Packages.bsuite, which is used by python3Packages.dm-haiku (and python3Packages.shimmy), which is used by a bunch of stuff. We’ll have to decide what to do about those before committing to this.

@emilazy emilazy mentioned this pull request Jul 26, 2024
Closed
SuperSandro2000
SuperSandro2000 reviewed Aug 22, 2024
View reviewed changes
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 23, 2024
@SuperSandro2000 SuperSandro2000 merged commit 9760aef into NixOS:master Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@onny onny onny approved these changes

@natsukium natsukium Awaiting requested review from natsukium

+1 more reviewer

@eclairevoyant eclairevoyant eclairevoyant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Sigmanificient @emilazy @onny @eclairevoyant @SuperSandro2000