Skip to content

boost{,-build}: fix building with llvm#329961

Merged
tomberek merged 2 commits intoNixOS:stagingfrom
ExpidusOS:fix/pkgsllvm/boost
Aug 16, 2024
Merged

boost{,-build}: fix building with llvm#329961
tomberek merged 2 commits intoNixOS:stagingfrom
ExpidusOS:fix/pkgsllvm/boost

Conversation

@RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Jul 25, 2024 •
edited
Loading

Description of changes

Fixes #320685

When building boost with LLVM, lld isn't found. The solution has been to force boost to not override --target being specified to clang.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from hjones2199 July 25, 2024 19:36
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 25, 2024
@RossComputerGuy RossComputerGuy marked this pull request as draft July 25, 2024 19:47
@RossComputerGuy RossComputerGuy changed the base branch from master to staging July 25, 2024 19:47
@RossComputerGuy RossComputerGuy marked this pull request as ready for review July 25, 2024 19:48
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package labels Jul 25, 2024
tomberek
tomberek approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds as expected

@tomberek tomberek merged commit 61c828c into NixOS:staging Aug 16, 2024
@RossComputerGuy RossComputerGuy deleted the fix/pkgsllvm/boost branch August 16, 2024 13:52
@FliegendeWurst FliegendeWurst mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomberek tomberek tomberek approved these changes

@hjones2199 hjones2199 Awaiting requested review from hjones2199

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: pkgsLLVM.boost

2 participants

@RossComputerGuy @tomberek