Revert "wayland: don't propagate bin output"#329523
Merged
flokli merged 1 commit intoNixOS:stagingfrom Jul 25, 2024
Merged
Conversation
This reverts commit 3f15de5. As commented in NixOS#328804 (comment), this broke quite some builds, and some of the interactions between wayland and its `.pc` file are still uncertain. Revert for now, and re-roll this later.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 101-500
wineee
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3f15de5.
As commented in
#328804 (comment), this broke quite some builds, and some of the interactions between wayland and its
.pcfile are still uncertain. Revert for now, and re-roll this later.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.