gst_all_1.gst-plugins-base: fix compilation#329452
gst_all_1.gst-plugins-base: fix compilation#329452flokli wants to merge 1 commit intoNixOS:stagingfrom
Conversation
`wayland-scanner` is in `wayland.bin`. This previously only worked as wayland propagated its `bin` output. See NixOS#328804 for context.
|
It seems that the host's This makes sense because nixpkgs/pkgs/stdenv/generic/setup.sh Lines 720 to 722 in 3178439 Host's I now see that host's |
|
We did some more digging, and while trying to build the gnome and plasma tests I uncovered a bunch of other binaries failing to build. I started changing some of these dependencies to It's unclear why "build systems" (CMakes' find_program`) pick up the host executable instead of the build executable. Also, the interaction between wayland-scanner, wayland.bin etc are still a bit unclear, we don't quite understand why we seem to be shipping our own custom However, we don't want to keep staging broken while doing this research, so let's revert the wayland change for now. |
|
Revert PR in #329523. |
This seems related to #318226; cc @paparodeo? |
yeah, strict deps is broken for cmake because cmake will pull executable from buiildInputs which is exactly what you don't want. FWIW i stopped working on the PR given all my other stalled PRs i didn't want to spend more time on it just to have it go nowhere. [edit] if i get a commitment from a committer to review and push it thru i'll resume working on it but am not planning on resuming otherwise. |
wayland-scanneris inwayland.bin.This previously only worked as wayland propagated its
binoutput.See #328804 for context.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.