Skip to content

python3Packages.deform: remove nose dependency#328917

Merged
emilazy merged 1 commit intoNixOS:masterfrom
lavafroth:python3Packages.deform/nose
Jul 22, 2024
Merged

python3Packages.deform: remove nose dependency#328917
emilazy merged 1 commit intoNixOS:masterfrom
lavafroth:python3Packages.deform/nose

Conversation

@lavafroth
Copy link
Contributor

@lavafroth lavafroth commented Jul 21, 2024 •
edited
Loading

Description of changes

Addresses #326513.

  • Dependency nose was removed from deform in version 2.0.15 (2020-12-10).
  • Set pyproject = true and build-system to setuptools.
  • Use the hash attribute for sha256.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 21, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 21, 2024
@ofborg ofborg bot requested a review from domenkozar July 21, 2024 14:36
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 21, 2024
@emilazy emilazy mentioned this pull request Jul 21, 2024
Closed
@emilazy
Copy link
Member

emilazy commented Jul 22, 2024

The URL in the comment beside the license is a 404. Going by their LICENSE.txt, we can see that the correct expression is license = [ lib.licenses.bsd3 lib.licenses.cc-by-30 ]. Could you correct that (and remove the with lib while you’re at it)?

There’s also some optional testing dependencies listed in setup.py that might be worth including, although perhaps a Selenium dependency would be a bit much.

@lavafroth lavafroth force-pushed the python3Packages.deform/nose branch from 8fd172a to ca61124 Compare July 22, 2024 11:56
@lavafroth
Copy link
Contributor Author

lavafroth commented Jul 22, 2024

I've corrected the licenses and removed the with lib in the meta attribute. About the extra dependencies, the functional tests are run using the run-selenium-tests.bash file which spins up a server. Let me know if we'd want to include those tests and dependencies as well.

@emilazy
Copy link
Member

emilazy commented Jul 22, 2024

Result of nixpkgs-review pr 328917 run on x86_64-darwin 1

4 packages built:
  • python311Packages.deform
  • python311Packages.deform.dist
  • python312Packages.deform
  • python312Packages.deform.dist

emilazy
emilazy approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; probably not worth running those heavy integration tests.

Let’s try out that merge button…

@emilazy emilazy merged commit ffed10e into NixOS:master Jul 22, 2024
@lavafroth lavafroth deleted the python3Packages.deform/nose branch January 14, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilazy emilazy emilazy approved these changes

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lavafroth @emilazy