Skip to content

buildGoPackage: deprecate#328876

Merged
fpletz merged 2 commits intoNixOS:masterfrom
katexochen:buildGoPackage/deprecate
Jul 21, 2024
Merged

buildGoPackage: deprecate#328876
fpletz merged 2 commits intoNixOS:masterfrom
katexochen:buildGoPackage/deprecate

Conversation

@katexochen
Copy link
Contributor

@katexochen katexochen commented Jul 21, 2024

Description of changes

Part of #318069

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. labels Jul 21, 2024
@katexochen katexochen mentioned this pull request Jul 21, 2024
35 tasks
@katexochen katexochen force-pushed the buildGoPackage/deprecate branch from 18f4594 to d0d6f8f Compare July 21, 2024 10:50
Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen force-pushed the buildGoPackage/deprecate branch from d0d6f8f to adf5bea Compare July 21, 2024 10:50
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All packages have been migrated.

@katexochen katexochen force-pushed the buildGoPackage/deprecate branch from adf5bea to 653e792 Compare July 21, 2024 11:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 21, 2024
@fpletz fpletz merged commit 719e8e6 into NixOS:master Jul 21, 2024
@katexochen katexochen deleted the buildGoPackage/deprecate branch July 22, 2024 04:01
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/deprecation-of-buildgopackage/46670/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants