Skip to content

nixos/sysusers: disallow hashedPasswordFile#328727

Closed
eclairevoyant wants to merge 1 commit intoNixOS:masterfrom
eclairevoyant:sysusers-assertion
Closed

nixos/sysusers: disallow hashedPasswordFile#328727
eclairevoyant wants to merge 1 commit intoNixOS:masterfrom
eclairevoyant:sysusers-assertion

Conversation

@eclairevoyant
Copy link
Contributor

Description of changes

Closes #318365 by highlighting the current limitation of the design.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@eclairevoyant eclairevoyant requested a review from a team as a code owner July 20, 2024 19:40
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Jul 20, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 20, 2024
@nikstur
Copy link
Contributor

nikstur commented Jul 20, 2024

I'm currently working on a fix for this. This assertion will soon be superfluous.

@eclairevoyant eclairevoyant mentioned this pull request Jul 21, 2024
13 tasks
@eclairevoyant eclairevoyant deleted the sysusers-assertion branch July 22, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

systemd.sysusers.enable breaks hashedPasswordFile

2 participants