emacsPackages.copilot: fix dependencies#328400
Closed
JaviMerino wants to merge 1 commit intoNixOS:masterfrom
Closed
emacsPackages.copilot: fix dependencies#328400JaviMerino wants to merge 1 commit intoNixOS:masterfrom
JaviMerino wants to merge 1 commit intoNixOS:masterfrom
Conversation
13 tasks
jian-lin
previously requested changes
Jul 19, 2024
Contributor
Author
|
I see. Another thing that works is: propagatedUserEnvPkgs = packageRequires ++ [ nodejs ];Is this preferred? |
Contributor
|
This is correct. But I plan to change |
Contributor
Author
In that case, should I close this pull request? |
Contributor
|
This PR can remain open and be closed atomically when my (future) PR is merged. |
ofborg
bot
added
10.rebuild-darwin: 1-10
Since f5380ca (emacsPackages.copilot: move nodejs to propagatedUserEnvPkgs, 2024-07-17), copilot fails to load: nix-build -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/f5380ca553a9f988fe47b99e28ed6b9975a375fa.tar.gz --expr "(import <nixpkgs> {}).emacsPackages.emacsWithPackages (epkgs: [epkgs.copilot])" && result/bin/emacs -q --eval "(use-package copilot)" [...] ■ Error (use-package): copilot/:catch: Cannot open load file: No such file or directory, s The required packages are not added to propagatedUserEnvPkgs. Add them manually until the genericBuild is fixed.
JaviMerino
force-pushed
the
fix_emacs_copilot
branch
from
de5f45a to
084f977
Compare
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Since #327952, copilot fails to load:
The required packages are not needed for building, only for running. Move them all to propagatedUserEnvPkgs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.