nixos/etc: handle mountpoints on top of /etc when switching#328221
Merged
Mic92 merged 2 commits intoNixOS:masterfrom Jul 18, 2024
Merged
nixos/etc: handle mountpoints on top of /etc when switching#328221Mic92 merged 2 commits intoNixOS:masterfrom
Mic92 merged 2 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
Contributor
Author
|
@ofborg test activation-etc-overlay-immutable activation-etc-overlay-mutable |
arianvp
reviewed
Jul 18, 2024
arianvp
approved these changes
Jul 18, 2024
ofborg
bot
added
10.rebuild-darwin: 0
The activation script that remounts the /etc overlay now handles other mount points on top of /etc by bind mounting them to the new temporary /etc overlay and then atomically revealing it.
ofborg
bot
added
the
11.by: package-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #303262 #291398
Should also fix the error reported here: #303262 (comment)
The activation script that remounts the /etc overlay now handles other mount points on top of /etc by bind mounting them to the new temporary /etc overlay and then atomically revealing it.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.