Skip to content

emacsPackages.copilot: trivialBuild -> melpaBuild#327952

Merged
jian-lin merged 2 commits intoNixOS:masterfrom
linj-fork:pr/clean-copilot
Jul 17, 2024
Merged

emacsPackages.copilot: trivialBuild -> melpaBuild#327952
jian-lin merged 2 commits intoNixOS:masterfrom
linj-fork:pr/clean-copilot

Conversation

@jian-lin
Copy link
Contributor

Description of changes

related: #278925

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jian-lin jian-lin requested a review from AndersonTorres July 17, 2024 15:48
@jian-lin jian-lin requested a review from adisbladis as a code owner July 17, 2024 15:48
@github-actions github-actions bot added the 6.topic: emacs Text editor label Jul 17, 2024
@AndersonTorres
Copy link
Member

OfBorg internal error(?)

@jian-lin
Copy link
Contributor Author

jian-lin commented Jul 17, 2024

OfBorg internal error(?)

No. The eval error is caused by #327944 and is fixed by #327957.


@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 17, 2024
@jian-lin jian-lin merged commit 8b6b30c into NixOS:master Jul 17, 2024
@jian-lin jian-lin deleted the pr/clean-copilot branch July 17, 2024 23:00
@JaviMerino
Copy link
Contributor

f5380ca breaks copilot for me. To test:

nix-build -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/f5380ca553a9f988fe47b99e28ed6b9975a375fa.tar.gz --expr "(import <nixpkgs> {}).emacsPackages.emacsWithPackages (epkgs: [epkgs.copilot])" && result/bin/emacs -q --eval "(use-package copilot)"
[...]
 ■  Error (use-package): copilot/:catch: Cannot open load file: No such file or directory, s

On the previous commit (639c992 (emacsPackages.copilot: trivialBuild -> melpaBuild, 2024-07-17)), it works fine:

nix-build -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/639c992f0405592984c65e7766c8c23d3be5cf16.tar.gz --expr "(import <nixpkgs> {}).emacsPackages.emacsWithPackages (epkgs: [epkgs.copilot])" && result/bin/emacs -q --eval "(use-package copilot)"

@jian-lin
Copy link
Contributor Author

@JaviMerino Thanks for the report. I have found the cause and will create a PR later.

@JaviMerino
Copy link
Contributor

@jian-lin Thanks! I created #328400 and then saw your message. I am not sure about it at all, feel free to reject it and create your own if it is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants