Skip to content

emacsPackages.ghc-mod: remove#327944

Merged
jian-lin merged 1 commit intoNixOS:masterfrom
linj-fork:pr/remove-ghc-mod
Jul 17, 2024
Merged

emacsPackages.ghc-mod: remove#327944
jian-lin merged 1 commit intoNixOS:masterfrom
linj-fork:pr/remove-ghc-mod

Conversation

@jian-lin
Copy link
Contributor

Description of changes

related: #278925

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jian-lin jian-lin requested a review from AndersonTorres July 17, 2024 15:07
@jian-lin jian-lin requested a review from adisbladis as a code owner July 17, 2024 15:07
@github-actions github-actions bot added the 6.topic: emacs Text editor label Jul 17, 2024
@jian-lin jian-lin merged commit 89e6cfb into NixOS:master Jul 17, 2024
@jian-lin jian-lin deleted the pr/remove-ghc-mod branch July 17, 2024 15:32
@Lord-Valen
Copy link
Contributor

So... this broke OfBorg. @grahamc

@jian-lin
Copy link
Contributor Author

jian-lin commented Jul 17, 2024

Sorry. The broken eval should already been fixed by #327957 5 hours ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants