Skip to content

bino3d: 1.6.8 -> 2.2#327642

Merged
pbsds merged 1 commit intoNixOS:masterfrom
emilazy:push-xkppnuxutmyo
Jul 22, 2024
Merged

bino3d: 1.6.8 -> 2.2#327642
pbsds merged 1 commit intoNixOS:masterfrom
emilazy:push-xkppnuxutmyo

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Jul 16, 2024

Description of changes

There was a comprehensive upstream rework that dropped many third‐party dependencies in favour of Qt 6 modules (including FFmpeg 4, which is what motivated me to do this). Accordingly, comprehensively rework the package for the update.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

There was a comprehensive upstream rework that dropped many
third‐party dependencies in favour of Qt 6 modules (including
FFmpeg 4, which is what motivated me to do this). Accordingly,
comprehensively rework the package for the update.
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 16, 2024
@pbsds pbsds requested a review from orivej-nixos July 20, 2024 23:21
@pbsbot
Copy link

pbsbot commented Jul 20, 2024

Result of nixpkgs-review pr 327642 run on x86_64-linux 1

1 package built:
  • bino3d

@pbsds pbsds merged commit 1bd0c80 into NixOS:master Jul 22, 2024
@emilazy emilazy mentioned this pull request Aug 1, 2024
13 tasks
@emilazy emilazy mentioned this pull request Aug 21, 2024
13 tasks
@emilazy emilazy deleted the push-xkppnuxutmyo branch August 26, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants