fwupd: 1.0.1 → 1.0.4 by jtojnar · Pull Request #32751 · NixOS/nixpkgs

jtojnar · 2017-12-17T08:17:51Z

Motivation for this change

Update and clean-up.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

jtojnar · 2017-12-17T13:19:49Z

Maybe we can wait for the pull request to be merged so we do not include the patch in repo?

disassembler · 2017-12-17T17:19:50Z

@GrahamcOfBorg build fwupd

GrahamcOfBorg

Failure for system: aarch64-linux


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

(use '--show-trace' to show detailed location information)

GrahamcOfBorg

Failure for system: x86_64-darwin

error: Package ‘fwupd-1.0.2’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/firmware/fwupd/default.nix:10 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg

Success for system: x86_64-linux

shrinking /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/lib/fwupd-plugins-3/libfu_plugin_steelseries.so
shrinking /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/lib/fwupd-plugins-3/libfu_plugin_amt.so
shrinking /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/lib/fwupd-plugins-3/libfu_plugin_colorhug.so
shrinking /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/lib/fwupd-plugins-3/libfu_plugin_thunderbolt_power.so
shrinking /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/lib/fwupd-plugins-3/libfu_plugin_unifying.so
shrinking /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/lib/libfwupd.so.2.0.0
stripping (with flags -S) in /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/lib  /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/libexec  /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2/bin 
patching script interpreter paths in /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2
checking for references to /tmp/nix-build-fwupd-1.0.2.drv-0 in /nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2...
/nix/store/kxl44x4605vcqm9sh01v631nbk8gay1i-fwupd-1.0.2

disassembler · 2017-12-17T18:29:49Z

looks good! I don't see any problems with merging with the patch, but if you want to wait, that's fine too.

jtojnar · 2017-12-17T18:39:25Z

Waiting few days should not be a problem.

Regarding the aarch64 failure, we could remove libsmbios dependency on that platform. Unless smbios is supported on ARM and the limitation is only artificial.

grahamc · 2017-12-17T19:21:33Z

Originally designed for Intel® processor architecture systems, SMBIOS now includes support for IA-32 (x86), x64 (x86-64, Intel64, AMD64, EM64T), Intel® Itanium® architecture, 32-bit ARM (Aarch32) and 64-bit ARM (Aarch64).

however our libsmbios does not live up to this claim:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./out/include -I./out/include -I./src/include -DLIBSMBIOS_LOCALEDIR=\"/nix/store/fvdfb1cy430j35n0vpb5c6n7a48sf2bi-libsmbios-2.3.3/share/locale\" -I./src/libsmbios_c/common -Wall -fPIC -fvisibility=hidden -g -O2 -DLIBSMBIOS_C_ALL_DYN_LINK -c src/libsmbios_c/token/token_da.c  -fPIC -DPIC -o src/libsmbios_c/token/.libs/out_libsmbios_c_la-token_da.o
src/libsmbios_c/cmos/cmos_linux.c:25:20: fatal error: sys/io.h: No such file or directory
 #include <sys/io.h>
                    ^
compilation terminated.
make[1]: *** [Makefile:2599: src/libsmbios_c/cmos/out_libsmbios_c_la-cmos_linux.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
src/libsmbios_c/smi/smi_linux.c: In function 'LINUX_dell_smi_obj_execute':
src/libsmbios_c/smi/smi_linux.c:308:9: warning: ignoring return value of 'strerror_r', declared with attribute warn_unused_result [-Wunused-result]
         strerror_r(errno, this->errstring + curstrsize, ERROR_BUFSIZE - curstrsize - 1);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: Leaving directory '/build/source'
make: *** [Makefile:3313: all-recursive] Error 1
builder for '/nix/store/15wkv5b5w3rfvcc8hxmvvs7i4r0d092v-libsmbios-2.3.3.drv' failed with exit code 2
cannot build derivation '/nix/store/grsmim0p1sp71rm5hj5a68np3znfkkyg-fwupd-1.0.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/grsmim0p1sp71rm5hj5a68np3znfkkyg-fwupd-1.0.2.drv' failed

I'm not sure we strictly need to handle the aarch64 failure at this time.

dtzWill · 2018-02-09T20:34:28Z

beep boop, ping! 1.0.4 is now out, FWIW!

dtzWill · 2018-02-09T20:38:45Z

This seems to do the trick:

From 6fb73e976372fbebf00e3d27e465dfa06121c3ee Mon Sep 17 00:00:00 2001
From: Will Dietz <[email protected]>
Date: Fri, 9 Feb 2018 14:37:23 -0600
Subject: [PATCH] fwupd: 1.0.3 -> 1.0.4

---
 pkgs/os-specific/linux/firmware/fwupd/default.nix | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/pkgs/os-specific/linux/firmware/fwupd/default.nix b/pkgs/os-specific/linux/firmware/fwupd/default.nix
index cf2216d3916..a67a052e5fe 100644
--- a/pkgs/os-specific/linux/firmware/fwupd/default.nix
+++ b/pkgs/os-specific/linux/firmware/fwupd/default.nix
@@ -1,18 +1,16 @@
-{ stdenv, fetchFromGitHub, gtk_doc, pkgconfig, gobjectIntrospection, intltool
+{ stdenv, fetchurl, gtk_doc, pkgconfig, gobjectIntrospection, intltool
 , libgudev, polkit, appstream-glib, gusb, sqlite, libarchive, glib_networking
 , libsoup, docbook2x, gpgme, libxslt, libelf, libsmbios, efivar, glibcLocales
 , fwupdate, libyaml, valgrind, meson, libuuid, pygobject3, colord
-, pillow, ninja, gcab, gnutls, python3Packages, wrapGAppsHook
+, pillow, ninja, gcab, gnutls, python3Packages, wrapGAppsHook, json_glib
 }:
 let
-  version = "1.0.3";
+  version = "1.0.4";
 in stdenv.mkDerivation {
   name = "fwupd-${version}";
-  src = fetchFromGitHub {
-    owner = "hughsie";
-    repo = "fwupd";
-    rev = version;
-    sha256 = "0vg9f1gzcvfd7jnfhvv0ylf04fy7cw31ykrim7qik6gbkhr4gr65";
+  src = fetchurl {
+    url = "https://people.freedesktop.org/~hughsient/releases/fwupd-${version}.tar.xz";
+    sha256 = "1n4d6fw3ffg051072hbxn106s52x2wlh5dh2kxwdfjsb5kh03ra3";
   };
 
   nativeBuildInputs = [
@@ -21,7 +19,7 @@ in stdenv.mkDerivation {
   ];
   buildInputs = [
     polkit appstream-glib gusb sqlite libarchive libsoup libelf libsmbios fwupdate libyaml
-    libgudev colord gpgme libuuid pillow gnutls glib_networking efivar
+    libgudev colord gpgme libuuid pillow gnutls glib_networking efivar json_glib
   ];
 
   LC_ALL = "en_US.UTF-8"; # For po/make-images
-- 
2.16.1

dtzWill · 2018-02-09T20:47:51Z

Hmm, for some reason using this (1.0.4) as well at least on master (1.0.1) doesn't seem to find updates.

Logs show messages like:

/var/lib/fwupd/remotes.d/lvfs/metadata.xml.gz file: cannot process file of type text/plain

Which is strange, considering:

$ file /var/lib/fwupd/remotes.d/lvfs/metadata.xml.gz
/var/lib/fwupd/remotes.d/lvfs/metadata.xml.gz: gzip compressed data, from Unix

Oh! Searching on upstream's github it appears you've discussed this and we need to update gcab, maybe?

fwupd/fwupd#318 (comment)

dtzWill · 2018-02-09T21:05:01Z

https://github.com/dtzWill/nixpkgs/tree/experimental/fwupd bumps our gcab and appstream-glib (with no testing of anything other than blitzing a path to fwupd 😇), if that's helpful.

Unfortunately still seeing the problem re:unable to parse text/plain. Dunno.

jtojnar · 2018-02-12T01:52:03Z

Oh! Searching on upstream's github it appears you've discussed this and we need to update gcab, maybe?

The issue I was reporting was caused by a broken error handler, it has nothing to do with gcab and it was fixed in fwupd/fwupd@5f733f2 – the “cannot process file of type text/plain” only triggered the bug.

I noticed your issue in 1.0.1 but since I only needed fwupd as a build dependency for gnome-software, I did not pay it much heed. It should probably be reported upstream.

dtzWill · 2018-02-12T02:23:20Z

Looks like we need shared_mime_info, something like this in preFixup: gappsWrapperArgs+=(--prefix XDG_DATA_DIRS : "${shared_mime_info}/share").

That seems to fix problems parsing the remotes' XML! Woo. But nothing seems to happen when I request the updates are performed/applied.

jtojnar · 2018-02-13T17:36:03Z

@dtzWill I merged your gcab update and appstream-glib update from my other branch.

And efivar was updated just now so I think this is ready to merge.

GrahamcOfBorg · 2018-02-13T17:39:15Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.3.3’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/os-specific/linux/libsmbios/default.nix:34 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-13T17:39:38Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘appstream-glib-0.7.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/libraries/appstream-glib/default.nix:43 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-14T15:47:15Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.3.3’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/os-specific/linux/libsmbios/default.nix:34 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-14T15:47:29Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘appstream-glib-0.7.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/libraries/appstream-glib/default.nix:43 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-14T15:48:08Z

Success on x86_64-linux (full log)

Partial log (click to expand)

checking for references to /build in /nix/store/7afryq6x0yavny7gddd6029m1fbcyx4r-fwupd-1.0.4-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/plrgp1v4pk29nmmci9kr6f8y6gqj6nks-fwupd-1.0.4-installedTests
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/plrgp1v4pk29nmmci9kr6f8y6gqj6nks-fwupd-1.0.4-installedTests
checking for references to /build in /nix/store/plrgp1v4pk29nmmci9kr6f8y6gqj6nks-fwupd-1.0.4-installedTests...
/nix/store/dpbdn5kmfy9acg5x0kf5vpvgsp6rki4v-appstream-glib-0.7.6
/nix/store/s9hgjjb3id9wymbrcwrfmqx459k4lxbr-efivar-34
/nix/store/3d3y6spkfi9vsvqp241ivkcss9cjfngw-fwupd-1.0.4
/nix/store/n75ay4va22mw4g7bb364qzrfyj7bfcx4-gcab-1.1
/nix/store/js1x5hw8w91pzzkj0fbaijjdwkyjxprz-gnome-desktop-testing-2016.1

GrahamcOfBorg · 2018-02-14T16:04:45Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.3.3’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/os-specific/linux/libsmbios/default.nix:34 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-14T16:04:46Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘appstream-glib-0.7.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/libraries/appstream-glib/default.nix:43 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-14T16:04:47Z

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/dpbdn5kmfy9acg5x0kf5vpvgsp6rki4v-appstream-glib-0.7.6
/nix/store/s9hgjjb3id9wymbrcwrfmqx459k4lxbr-efivar-34
/nix/store/3d3y6spkfi9vsvqp241ivkcss9cjfngw-fwupd-1.0.4
/nix/store/n75ay4va22mw4g7bb364qzrfyj7bfcx4-gcab-1.1
/nix/store/js1x5hw8w91pzzkj0fbaijjdwkyjxprz-gnome-desktop-testing-2016.1

GrahamcOfBorg · 2018-02-15T00:22:46Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.3.3’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/os-specific/linux/libsmbios/default.nix:34 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-15T00:22:51Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘appstream-glib-0.7.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/libraries/appstream-glib/default.nix:43 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-15T00:25:02Z

Success on x86_64-linux (full log)

Partial log (click to expand)

patching script interpreter paths in /nix/store/7afryq6x0yavny7gddd6029m1fbcyx4r-fwupd-1.0.4-man
checking for references to /tmp/nix-build-fwupd-1.0.4.drv-0 in /nix/store/7afryq6x0yavny7gddd6029m1fbcyx4r-fwupd-1.0.4-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/plrgp1v4pk29nmmci9kr6f8y6gqj6nks-fwupd-1.0.4-installedTests
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/plrgp1v4pk29nmmci9kr6f8y6gqj6nks-fwupd-1.0.4-installedTests
checking for references to /tmp/nix-build-fwupd-1.0.4.drv-0 in /nix/store/plrgp1v4pk29nmmci9kr6f8y6gqj6nks-fwupd-1.0.4-installedTests...
/nix/store/dpbdn5kmfy9acg5x0kf5vpvgsp6rki4v-appstream-glib-0.7.6
/nix/store/s9hgjjb3id9wymbrcwrfmqx459k4lxbr-efivar-34
/nix/store/3d3y6spkfi9vsvqp241ivkcss9cjfngw-fwupd-1.0.4
/nix/store/n75ay4va22mw4g7bb364qzrfyj7bfcx4-gcab-1.1

vcunat · 2018-02-16T11:43:38Z

nixos/release.nix

  tests.firefox = callTest tests/firefox.nix {};
  tests.firewall = callTest tests/firewall.nix {};
  tests.fleet = callTestOnTheseSystems ["x86_64-linux"] tests/fleet.nix {};
+  tests.fwupd = callTest tests/fwupd.nix {};


This is a problem on Hydra. It causes build during evaluation, most likely due to the code around listFiles. It's probably the cause why it doesn't have resources to evaluate trunk-combined ATM. I disabled the test for now.

There's an issue already :-) #32142

Right, sorry about that. Still the same old #32142, still not sure how to best fix it.

jtojnar added the 8.has: package (update) This PR updates a package to a newer version label Dec 17, 2017

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 17, 2017

orivej approved these changes Dec 17, 2017

View reviewed changes

GrahamcOfBorg reviewed Dec 17, 2017

View reviewed changes

disassembler approved these changes Dec 17, 2017

View reviewed changes

jtojnar force-pushed the fwupd-1.0.2 branch from 030413a to 1a4515e Compare January 19, 2018 20:16

jtojnar changed the title ~~fwupd: 1.0.1 → 1.0.2~~ fwupd: 1.0.1 → 1.0.3 Jan 19, 2018

jtojnar force-pushed the fwupd-1.0.2 branch from 1a4515e to 3a5e2b5 Compare February 13, 2018 17:30

jtojnar changed the title ~~fwupd: 1.0.1 → 1.0.3~~ fwupd: 1.0.1 → 1.0.4 Feb 13, 2018

jtojnar force-pushed the fwupd-1.0.2 branch from be760b4 to 08fc463 Compare February 14, 2018 15:50

jtojnar added the 1 - Ready label Feb 14, 2018

jtojnar mentioned this pull request Feb 14, 2018

Add installed tests #34987

Open

44 tasks

jtojnar and others added 12 commits February 15, 2018 01:11

efivar: 30 → 34

f94a173

fwupd: 1.0.1 → 1.0.4

fb29a09

gcab: 0.7 -> 1.1

88e977d

fwupd: shared_mime_info is needed!

8340cc5

appstream-glib: 0.7.2 → 0.7.6

6665d4f

fwupd: use correct libelf

2ea6f25

nixos/fwupd: add maintainers

640916d

fwupd: enable tests

be54e4b

nixos/fwupd: add test

201cc15

fwupd: add devdoc

a5e4658

fwupd: add manpage

200a08e

fwupd: clean up

f118d2b

jtojnar force-pushed the fwupd-1.0.2 branch 2 times, most recently from 03617f7 to f118d2b Compare February 15, 2018 00:14

jtojnar merged commit c6283e6 into NixOS:master Feb 15, 2018

jtojnar deleted the fwupd-1.0.2 branch February 15, 2018 00:18

jtojnar mentioned this pull request Feb 15, 2018

Leftover -I${efivar}/include/efivar CFLAGS #35011

Closed

vcunat reviewed Feb 16, 2018

View reviewed changes

Uh oh!

Conversation

jtojnar commented Dec 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

jtojnar commented Dec 17, 2017

Uh oh!

disassembler commented Dec 17, 2017

Uh oh!

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

Uh oh!

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

Uh oh!

GrahamcOfBorg left a comment

Choose a reason for hiding this comment

Uh oh!

disassembler commented Dec 17, 2017

Uh oh!

jtojnar commented Dec 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

grahamc commented Dec 17, 2017

Uh oh!

dtzWill commented Feb 9, 2018

Uh oh!

dtzWill commented Feb 9, 2018

Uh oh!

dtzWill commented Feb 9, 2018

Uh oh!

dtzWill commented Feb 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jtojnar commented Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dtzWill commented Feb 12, 2018

Uh oh!

jtojnar commented Feb 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GrahamcOfBorg commented Feb 13, 2018

Uh oh!

GrahamcOfBorg commented Feb 13, 2018

Uh oh!

GrahamcOfBorg commented Feb 14, 2018

Uh oh!

GrahamcOfBorg commented Feb 14, 2018

Uh oh!

GrahamcOfBorg commented Feb 14, 2018

Uh oh!

GrahamcOfBorg commented Feb 14, 2018

Uh oh!

GrahamcOfBorg commented Feb 14, 2018

Uh oh!

GrahamcOfBorg commented Feb 14, 2018

Uh oh!

GrahamcOfBorg commented Feb 15, 2018

Uh oh!

GrahamcOfBorg commented Feb 15, 2018

Uh oh!

GrahamcOfBorg commented Feb 15, 2018

Uh oh!

vcunat Feb 16, 2018

Choose a reason for hiding this comment

Uh oh!

vcunat Feb 16, 2018

Choose a reason for hiding this comment

Uh oh!

jtojnar Feb 16, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

jtojnar commented Dec 17, 2017 •

edited

Loading

jtojnar commented Dec 17, 2017 •

edited

Loading

dtzWill commented Feb 9, 2018 •

edited

Loading

jtojnar commented Feb 12, 2018 •

edited

Loading

jtojnar commented Feb 13, 2018 •

edited

Loading