Skip to content

python3Pakcages.pid: remove nose dependency#327372

Closed
mindstorms6 wants to merge 170 commits intoNixOS:masterfrom
mindstorms6:python3packages-pid-remove-nose
Closed

python3Pakcages.pid: remove nose dependency#327372
mindstorms6 wants to merge 170 commits intoNixOS:masterfrom
mindstorms6:python3packages-pid-remove-nose

Conversation

@mindstorms6
Copy link
Member

@mindstorms6 mindstorms6 commented Jul 15, 2024 •
edited
Loading

Description of changes

pid package no longer needs nose as of this commit - remove nose dependency.

Addresses #326513.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 15, 2024
@emilazy
Copy link
Member

emilazy commented Jul 15, 2024 •
edited
Loading

That commit was merged after the latest upstream release, so we’ll have to vendor the patch for now, like in #326665. Please switch over to pyproject = true; build-system = [ setuptools ]; as well. I’m confused by the “No tests included” comment too… seems like there are tests? Would we still run them after this PR? We might need pytestCheckHook.

Also, typo: python3Pakcages.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 15, 2024
@emilazy emilazy mentioned this pull request Jul 16, 2024
Closed
@emilazy
Copy link
Member

emilazy commented Jul 31, 2024

Just checking in on if you’re planning to update this?

@mindstorms6
Copy link
Member Author

mindstorms6 commented Aug 5, 2024

Yes sorry - been traveling. If it's blocking something - feel free to discard.

jian-lin and others added 22 commits August 14, 2024 23:10
@jian-lin @mindstorms6
librime-lua: init at 0-unstable-2024-05-19
bdec5a3
@jian-lin @mindstorms6
librime: add librime-lua plugin by default following Arch Linux
7974e46 
https://gitlab.archlinux.org/archlinux/packaging/packages/librime/-/blob/0da73fbd402865409d0f4ef186fb763e9b4523e2/PKGBUILD#L22
@jhol @mindstorms6
conan: 2.0.17 -> 2.5.0
4168846
@r-ryantm @mindstorms6
tcpreplay: 4.4.4 -> 4.5.1
23d5aa1
@DerRockWolf @mindstorms6
stackit-cli: 0.8.1 -> 0.9.0
e56e425
@b-rodrigues @mindstorms6
quarto: 1.5.53 -> 1.5.54
1529e1f
@gador @mindstorms6
blendfarm: init at 1.1.6
d70b7d1 
Signed-off-by: Florian Brandes <[email protected]>
@gador @mindstorms6
nixos/blendfarm: init
6814763 
Signed-off-by: Florian Brandes <[email protected]>
@r-ryantm @mindstorms6
python312Packages.pylink-square: 1.2.0 -> 1.2.1
8950ac6
@natsukium @mindstorms6
python312Packages.pylink-square: switch to pypa build
03d5e61
@rnhmjoj @mindstorms6
bdf2psf: 1.228 -> 1.229
76bebd5
@K900 @mindstorms6
teamspeak5_client: add mesa dependency
7a88683 
It doesn't require mesa.drivers, but it does require libgbm
@r-ryantm @mindstorms6
python312Packages.twitchapi: 4.2.0 -> 4.2.1
b3d2232
@Sigmanificient @mindstorms6
tuifimanager: 4.0.6 -> 4.1.7 (NixOS#326616)
a12ef44
@liam-murphy14 @mindstorms6
maintainers: add liammurphy14
db6314d
@liam-murphy14 @yayayayaka @mindstorms6
electron-chromedriver: init at 29.4.4, 30.2.0, 31.2.0
a37ba3b 
Co-Authored-By: Yaya <[email protected]>
@yayayayaka @mindstorms6
electron: support updating chromedriver with update.py
f054325
@r-ryantm @mindstorms6
tinymist: 0.11.14 -> 0.11.15
8513b8b
@r-ryantm @mindstorms6
kyverno: 1.12.4 -> 1.12.5 (NixOS#326612)
dc4953e
@r-ryantm @mindstorms6
nomad-driver-podman: 0.5.2 -> 0.6.0
0070c21
@siddarthkay @mindstorms6
xcbeautify: 1.4.0 -> 2.4.1
c817c48
@r-ryantm @mindstorms6
emuflight-configurator: 0.4.1 -> 0.4.3
f9559a7
@mindstorms6 mindstorms6 force-pushed the python3packages-pid-remove-nose branch from d4de39b to c39f6cd Compare August 15, 2024 03:13
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: vim Advanced text editor 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) labels Aug 15, 2024
@mindstorms6 mindstorms6 marked this pull request as draft August 15, 2024 03:13
@mindstorms6 mindstorms6 mentioned this pull request Aug 15, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@figsoda figsoda Awaiting requested review from figsoda

@natsukium natsukium Awaiting requested review from natsukium

Assignees

No one assigned

Labels

6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: kernel The Linux kernel 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vim Advanced text editor 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.