Skip to content

mackup: remove nose dependency and modernize#327240

Merged
emilazy merged 1 commit intoNixOS:masterfrom
pyrox0:denose/mackup
Jul 29, 2024
Merged

mackup: remove nose dependency and modernize#327240
emilazy merged 1 commit intoNixOS:masterfrom
pyrox0:denose/mackup

Conversation

@pyrox0
Copy link
Member

@pyrox0 pyrox0 commented Jul 15, 2024

Description of changes

Part of #326513

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 15, 2024
@ofborg ofborg bot requested a review from luftmensch-luftmensch July 15, 2024 02:08
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 15, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The six dependency was also removed upstream.

@pyrox0 pyrox0 force-pushed the denose/mackup branch 2 times, most recently from 19b7b10 to e9e16c1 Compare July 17, 2024 01:44
@emilazy
Copy link
Member

emilazy commented Jul 27, 2024

Ah, this doesn’t build because the six and nose changes are after the last release, sorry; I assumed the version bump had already happened. You can re‐add it for now.

@pyrox0 pyrox0 requested a review from emilazy July 29, 2024 05:21
@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jul 29, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Result of nixpkgs-review pr 327240 run on x86_64-linux 1

3 packages built:
  • mackup
  • mackup.dist
  • nixpkgs-manual

@emilazy emilazy merged commit d8fbe30 into NixOS:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants