python312Packages.ofxhome: remove nose and fix tests#327239
python312Packages.ofxhome: remove nose and fix tests#327239emilazy merged 1 commit intoNixOS:masterfrom
Conversation
emilazy
left a comment
There was a problem hiding this comment.
This thing just doesn’t work at all. It’s a client for a site that has been dead for 7 years.
I really want to say we should just put this one out of its misery, but I guess it has one connection to a package we might conceivably want to work in Nixpkgs through ofxclient and ledger-autosync. There’s a report here: egh/ledger-autosync#141.
I see a few options here:
-
Send a PR to
ledger-autosyncmoving it to the more modernofxtools; it looks like there isn’t that much code or API surface being exercised, although it would be a compatibility‐breaking change because they pass a configuration file directly toofxclient. This would be firmly supererogatory FOSS ecosystem behaviour and I don’t at all expect you to actually do it. -
Patch
ofxhomeout ofofxclient, send a probably‐futile upstream PR to the same maintainer’s other dormant project. But that might be gnarly and it’s possible they’re quite coupled. -
Keep this zombie package alive just for its reverse dependencies.
-
Remove
ledger-autosyncentirely (but apparently even in its current state it does still work with downloaded OFX files).
Do you have any inclinations here? I don’t have any desire to block doing 3 as this is clearly an improvement on the status quo, but this kind of rot does make me wish we could take the opportunity to apply a little pressure on the ecosystem here. Don’t burn yourself out sending patches to random upstreams though :) It seems like ledger-autosync still has users and still works, so it’s probably best to just keep this building for now and hope that someone who actually cares migrates ledger-autosync to ofxtools.
emilazy
left a comment
There was a problem hiding this comment.
Result of nixpkgs-review pr 327239 run on x86_64-linux 1
8 packages built:
- python311Packages.ofxclient
- python311Packages.ofxclient.dist
- python311Packages.ofxhome
- python311Packages.ofxhome.dist
- python312Packages.ofxclient
- python312Packages.ofxclient.dist
- python312Packages.ofxhome
- python312Packages.ofxhome.dist
Merging this for now; hopefully downstreams will catch up in time. Thanks!
Description of changes
Part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.