cmake-lint: remove nose dependency#327220
Conversation
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
No strong opinions about the coverage testing (is there an obstacle to just running the unmodified test suite?) but this looks good to me; upstream doesn’t mention nose at all any more. I wonder how many totally unused Python dependencies we have in tree…
ofborg
bot
added
10.rebuild-darwin: 1-10
There's no obstacle(afaik) to running it besides adding the pytest-cov dependency to nativeCheckInputs, it's just not useful to run them in Nix checks. |
|
I’d personally be willing to spend a build dependency and some CPU cycles to avoid the churn of a patch that might rot and block updates, but you’re right that it is kind of pointless to run. I’ll leave it to the maintainer’s discretion :) |
wegank
added
the
12.approvals: 1
|
It is guidance by the python people that pytest-cov (like all other linters and the like) is not to be used and be patched our or now be replaced with pytest-cov-stub. |
5 participants
Description of changes
Removes a dependency on nose, part of #326513
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.