adafruit-nrfutil: remove nose and modernize#327199
Merged
pbsds merged 1 commit intoNixOS:masterfrom Jul 19, 2024
Merged
Conversation
emilazy
approved these changes
Jul 14, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
You’re on fire! Thanks for taking the initiative with these.
Member
|
Uhh, by the way, this should apparently be |
Member
Author
|
sigh good ol' licensing issues. I'll update it. |
Member
|
I misspoke slightly, it’s at least |
pyrox0
force-pushed
the
denose/adafruit-nrfutil
branch
from
7d29984 to
14372a7
Compare
pyrox0
force-pushed
the
denose/adafruit-nrfutil
branch
from
14372a7 to
91edc51
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
|
Result of 2 packages built:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes nose and just uses pytest's compatibility layer for tests.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.