python3Packages.yarg: remove nose and modernize#327170
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 1-10
|
It looks like upstream still claims a nose dependency in |
yes, the same tests are still being run, using pytest's nose compatibility layer. |
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Looks good, thank you for sending this upstream! Sorry that I can’t merge these myself…
By the way, I only just recently learned about fetchpatch2 and #257446 – if you’re a best‐practices stickler like me then you might be interested in starting to use fetchpatch2 { url = "…?full_index=1"; } for GitHub patches. (But this is absolutely not worth holding up this PR over, given how ubiquitous fetchpatch is already.)
|
I'm very much a stickler for good code and best practices, updated to use fetchpatch2/full_index! I'll keep it in mind for future PRs as well, that's a good thing to know about! |
|
@ofborg build python3Packages.yarg |
4 participants
Description of changes
Updates the yarg derivation to remove the dependency on nose, and updates the Nix code to follow modern packaging standards. Builds and tests just fine for me.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.