python3Packages.python-fedora: remove nose#327169
Merged
wegank merged 1 commit intoNixOS:masterfrom Jul 15, 2024
Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
Aleksanaa
approved these changes
Jul 15, 2024
Member
Aleksanaa
left a comment
Aleksanaa
left a comment
There was a problem hiding this comment.
Please reword as python3Packages.python-fedora: remove nose
wegank
added
the
12.approvals: 2
wegank
changed the title
mindstorms6
pushed a commit
to mindstorms6/nixpkgs
that referenced
this pull request
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes python-fedora's dependency on nose, which unbreaks it on python 3.12. It works just fine with pytestCheckHook.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.