Skip to content

python3Packages.gocardless-pro: remove nose dependency#326766

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
lavafroth:python3Packages.gocardless-pro/nose
Jul 14, 2024
Merged

python3Packages.gocardless-pro: remove nose dependency#326766
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
lavafroth:python3Packages.gocardless-pro/nose

Conversation

@lavafroth
Copy link
Contributor

Description of changes

Addresses #326513.

Dependency nose was removed in favor of pytest in version 1.46.2 (See changlelog).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 13, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 13, 2024
@emilazy
Copy link
Member

emilazy commented Jul 14, 2024

Thanks! Can you handle the PEP 517 migration by replacing the format with pyproject = true; and switching the setuptools dependency to build-system = [ setuptools ];?

Addresses NixOS#326513
Dependency `nose` was removed in favor of pytest in version 1.46.2.
@lavafroth lavafroth force-pushed the python3Packages.gocardless-pro/nose branch from 324c02a to c757e22 Compare July 14, 2024 13:37
@lavafroth
Copy link
Contributor Author

Done!

@SuperSandro2000
Copy link
Member

@ofborg build python3Packages.gocardless-pro

@SuperSandro2000 SuperSandro2000 merged commit b361c1b into NixOS:master Jul 14, 2024
@lavafroth lavafroth deleted the python3Packages.gocardless-pro/nose branch July 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants