Skip to content

python3Packages.expiringdict: Python 3.12 compatibility#326665

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
AndrewKvalheim:python3Packages.expiringdict/python-3.12
Jul 14, 2024
Merged

python3Packages.expiringdict: Python 3.12 compatibility#326665
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
AndrewKvalheim:python3Packages.expiringdict/python-3.12

Conversation

@AndrewKvalheim
Copy link
Member

Description of changes

Addresses #326513 and upstream incompatibility with Python 3.12.

Resolves build failures of:

  • python3Packages.checkdmarc
  • python3Packages.mailsuite

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 12, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 13, 2024
@ofborg ofborg bot requested a review from gravndal July 13, 2024 02:32
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 13, 2024
@emilazy
Copy link
Member

emilazy commented Jul 13, 2024

Could you migrate this to the PEP 517 pyproject = true; build-system = [ setuptools ]; at the same time?

@AndrewKvalheim AndrewKvalheim force-pushed the python3Packages.expiringdict/python-3.12 branch from 1516fd5 to ead5eba Compare July 13, 2024 13:03
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000 SuperSandro2000 merged commit 70ef53e into NixOS:master Jul 14, 2024
@AndrewKvalheim AndrewKvalheim deleted the python3Packages.expiringdict/python-3.12 branch August 24, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants