Skip to content

swift: fix build and mark as unbroken on darwin#326588

Merged
corngood merged 2 commits intoNixOS:masterfrom
corngood:swift
Jul 13, 2024
Merged

swift: fix build and mark as unbroken on darwin#326588
corngood merged 2 commits intoNixOS:masterfrom
corngood:swift

Conversation

@corngood
Copy link
Contributor

@corngood corngood commented Jul 12, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@corngood corngood marked this pull request as draft July 12, 2024 15:45
@corngood
Copy link
Contributor Author

Result of nixpkgs-review pr 326588 run on x86_64-linux 1

23 packages built:
  • deadbeef
  • deadbeef-with-plugins
  • ghidra-extensions.ghidraninja-ghidra-scripts
  • sourcekit-lsp
  • swift
  • swift-corelibs-libdispatch
  • swift-corelibs-libdispatch.dev
  • swift-corelibs-libdispatch.man
  • swift-format
  • swift.man
  • swiftPackages.Foundation
  • swiftPackages.Foundation.dev
  • swiftPackages.XCTest
  • swiftPackages.swift-docc
  • swiftPackages.swift-driver
  • swiftPackages.swift-unwrapped
  • swiftPackages.swift-unwrapped.dev
  • swiftPackages.swift-unwrapped.doc
  • swiftPackages.swift-unwrapped.lib
  • swiftPackages.swift-unwrapped.man
  • swiftPackages.swiftNoSwiftDriver
  • swiftPackages.swiftNoSwiftDriver.man
  • swiftPackages.swiftpm

@corngood
Copy link
Contributor Author

Result of nixpkgs-review pr 326588 run on aarch64-darwin 1

9 packages marked as broken and skipped:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • ki
  • ki.dist
  • mnemosyne
  • mnemosyne.dist
  • mpc-qt
13 packages failed to build:
  • dotnetCorePackages.dotnet_8.aspnetcore
  • dotnetCorePackages.dotnet_8.runtime
  • dotnetCorePackages.dotnet_8.sdk
  • dotnetCorePackages.dotnet_8.sdk.artifacts
  • dotnetCorePackages.dotnet_8.sdk.packages
  • dotnetCorePackages.dotnet_8.vmr
  • dotnetCorePackages.dotnet_9.aspnetcore
  • dotnetCorePackages.dotnet_9.runtime
  • dotnetCorePackages.dotnet_9.sdk
  • dotnetCorePackages.dotnet_9.sdk.artifacts
  • dotnetCorePackages.dotnet_9.sdk.packages
  • dotnetCorePackages.dotnet_9.vmr
  • gonic
53 packages built:
  • ani-cli
  • cplay-ng
  • cplay-ng.dist
  • curseradio
  • curseradio.dist
  • dark-mode-notify
  • dmlive
  • dockutil
  • dra-cla
  • ff2mpv
  • ff2mpv-go
  • ghidra-extensions.ghidraninja-ghidra-scripts
  • hydrus
  • hydrus.doc
  • invidtui
  • klipperscreen
  • mov-cli
  • mov-cli.dist
  • mpv
  • mpv-unwrapped
  • mpv-unwrapped.dev
  • mpv-unwrapped.doc
  • mpv-unwrapped.man
  • needle
  • photoqt
  • plex-media-player
  • python311Packages.mpv
  • python311Packages.mpv.dist
  • python312Packages.mpv
  • python312Packages.mpv.dist
  • somafm-cli
  • sourcekit-lsp
  • subtitleedit
  • supersonic
  • swift
  • swift-format
  • swift.man
  • swiftPackages.XCTest
  • swiftPackages.swift-docc
  • swiftPackages.swift-driver
  • swiftPackages.swift-unwrapped
  • swiftPackages.swift-unwrapped.dev
  • swiftPackages.swift-unwrapped.doc
  • swiftPackages.swift-unwrapped.lib
  • swiftPackages.swift-unwrapped.man
  • swiftPackages.swiftNoSwiftDriver
  • swiftPackages.swiftNoSwiftDriver.man
  • swiftPackages.swiftpm
  • tomato-c
  • wtwitch
  • xcodes
  • youtube-tui
  • ytfzf

@corngood corngood marked this pull request as ready for review July 12, 2024 16:50
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 12, 2024
Copy link
Member

@emilazy emilazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @risicle #318674

For context: Swift builds and uses its own Clang(!) which I guess doesn’t like this flag? Not sure if there’s a “better” resolution here.

@ofborg ofborg bot requested review from Trundle, dduan, dtzWill, stephank and trepetti July 12, 2024 18:40
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 12, 2024
@corngood
Copy link
Contributor Author

I'll take care of the dotnet failures separately. It seems to be unrelated to swift and just some breakage that slipped in while everything was disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants