binwalk: migrate to fork, 2.4.1#326295
Conversation
github-actions
bot
added
the
6.topic: python
|
Result of 12 packages built:
|
ofborg
bot
added
8.has: package (new)
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Arch, Void, Exherbo, and MSYS2 all use this fork too. At a glance, the new upstream seems reputable, development looks reasonably active, and they seem to understand what a licence is…
Do you know how this might affect the weird test behaviour in #325623?
Result of nixpkgs-review pr 326295 run on aarch64-darwin 1
1 package marked as broken and skipped:
- ghidra-extensions.ghidraninja-ghidra-scripts
11 packages built:
- binwalk (python312Packages.binwalk)
- binwalk.dist (python312Packages.binwalk.dist)
- diffoscope
- diffoscope.dist
- diffoscope.man
- python311Packages.binwalk
- python311Packages.binwalk-full
- python311Packages.binwalk-full.dist
- python311Packages.binwalk.dist
- python312Packages.binwalk-full
- python312Packages.binwalk-full.dist
|
Result of 1 package marked as broken and skipped:
11 packages built:
|
|
Good question. I'm actually wondering the same thing myself. How should it manifest, as a test failure in diffoscope? I guess I'm not seeing that if so. Maybe we can find evidence in the 77 or so commits that this fork has on top of the original repository. |
|
Yeah, I guess this fork is fine but the other patch wasn’t, somehow…? Or skipping the checks on 3.12 somehow broke it in the other PR? But hey, it built fine… cc @philiptaron |
|
Result of 1 package marked as broken and skipped:
11 packages built:
|
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.05
git worktree add -d .worktree/backport-326295-to-release-24.05 origin/release-24.05
cd .worktree/backport-326295-to-release-24.05
git switch --create backport-326295-to-release-24.05
git cherry-pick -x c9998d08693c680857e567d034c2bf0de661c10b c734673fef56864c7d0d2a70e66b344472f3456e |
|
I don’t think the 3.12 switch is on 24.05…? |
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Thanks. I'll close #325623.
binwalk: migrate to fork, 2.4.1
4 participants
Description of changes
Binwalk has gone unmaintained for some time, unfortunately. Thankfully our friends at Gentoo have been maintaining a fork. It is currently used by both Gentoo and Alpine.
This PR moves to the fork and updates the derivation accordingly. It also migrates to the PEP517 builder.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.